auth: avoid duplicate getpwnam lookup#665
Open
Komzpa wants to merge 1 commit into
Open
Conversation
getpwnamallow() used getpwnam() to fill ci->user_invalid for Match processing, then called getpwnam() again for the returned passwd record. Reuse the first lookup on non-AIX systems. Keep the second lookup under AIX after aix_setauthdb(), preserving the auth database switch semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getpwnamallow()calledgetpwnam(user)once to fillci->user_invalidbeforeMatchprocessing, then called it again for thereturned passwd record.
Reuse the first lookup on non-AIX systems. On AIX, keep the second lookup after
aix_setauthdb(user), preserving the existing auth database switch semanticsbefore restoring the previous auth database.
Tests
autoreconf && ./configure --prefix=/tmp/openssh-auth-getpwnamallow-install && make -j8make LTESTS='cfgmatch allow-deny-users authinfo' t-exec